Discussion:
ISO_Left_Tab
Jürgen Spitzmüller
2014-10-08 07:27:40 UTC
Permalink
In site.bind, we have the following binding:

\bind "~S-ISO_Left_Tab" "cell-backward"

Since ISO_Left_Tab itself is defined as Shift+Tab, ~S-ISO_Left_Tab is
apparently interpreted as Shift+Shift+Tab = Tab, which results in the wrong
binding of Tab to cell-backwards.

See this discussion:
http://marc.info/?l=lyx-users&m=141234899011761&w=2

Am I right that the binding should thus be changed to

\bind "ISO_Left_Tab" "cell-backward"

JÃŒrgen
Jean-Marc Lasgouttes
2014-10-08 07:43:06 UTC
Permalink
Post by Jürgen Spitzmüller
\bind "~S-ISO_Left_Tab" "cell-backward"
Since ISO_Left_Tab itself is defined as Shift+Tab, ~S-ISO_Left_Tab is
apparently interpreted as Shift+Shift+Tab = Tab, which results in the
wrong binding of Tab to cell-backwards.
http://marc.info/?l=lyx-users&m=141234899011761&w=2
Am I right that the binding should thus be changed to
\bind "ISO_Left_Tab" "cell-backward"
This is weird, doing this change should not be necessary ~S is supposed
to mean 'either with or without S pressed'. The official Qt name for
this key is BackTab. Does it work better?

Did you try to get some debug output?

JMarc
Jürgen Spitzmüller
2014-10-08 07:57:51 UTC
Permalink
Post by Jürgen Spitzmüller
\bind "~S-ISO_Left_Tab" "cell-backward"
Since ISO_Left_Tab itself is defined as Shift+Tab, ~S-ISO_Left_Tab is
apparently interpreted as Shift+Shift+Tab = Tab, which results in the
wrong binding of Tab to cell-backwards.
http://marc.info/?l=lyx-users&m=141234899011761&w=2
Am I right that the binding should thus be changed to
\bind "ISO_Left_Tab" "cell-backward"
This is weird, doing this change should not be necessary ~S is supposed to
mean 'either with or without S pressed'. The official Qt name for this key
is BackTab. Does it work better?
This made me check the sources, and I find in GuiKeySymbol::string_to_qkey:

if (str == "ISO_Left_Tab") return Qt::Key_Tab;

This is supposed to return Qt::Key_Backtab instead, no? (I have not checked
yet)
Did you try to get some debug output?
Yes, I get immediately "cell-backwards" on hitting Shift-Tab. Also, the
dialog displays the binding as "Tab".

JÃŒrgen
JMarc
Jean-Marc Lasgouttes
2014-10-08 08:12:43 UTC
Permalink
Post by Jürgen Spitzmüller
if (str == "ISO_Left_Tab") return Qt::Key_Tab;
This is supposed to return Qt::Key_Backtab instead, no? (I have not
checked yet)
I would say this is the bug you are looking for.

JMarc
Jürgen Spitzmüller
2014-10-08 08:58:12 UTC
Permalink
Post by Jean-Marc Lasgouttes
I would say this is the bug you are looking for.
I verified it is and committed a fix to master. Should also go to branch.

JÃŒrgen
Post by Jean-Marc Lasgouttes
JMarc
Loading...