Discussion:
[LyX/master] Graphics only handle inset-modify graphics (#8262)
Richard Heck
2014-05-17 13:53:06 UTC
Permalink
commit 4bd0941b4fec92354b52bfe82835f7ebb8981d21
Date: Wed Feb 5 17:59:39 2014 -0500
Graphics only handle inset-modify graphics (#8262)
inset-modify tabular and others are now passed on.
diff --git a/src/insets/InsetGraphics.cpp b/src/insets/InsetGraphics.cpp
index 70b43c4..08d7e82 100644
--- a/src/insets/InsetGraphics.cpp
+++ b/src/insets/InsetGraphics.cpp
@@ -240,8 +245,10 @@ bool InsetGraphics::getStatus(Cursor & cur, FuncRequest const & cmd,
FuncStatus & flag) const
{
switch (cmd.action()) {
+ if (cmd.getArg(0) != "graphics")
+ return Inset::getStatus(cur, cmd, flag);
In cases like this, I prefer we add a comment of the form:

// fall through

to make it clear that what is about to happen is intended.
flag.setEnabled(true);
Richard
Scott Kostyshak
2014-05-18 08:32:10 UTC
Permalink
Post by Richard Heck
+ if (cmd.getArg(0) != "graphics")
+ return Inset::getStatus(cur, cmd, flag);
// fall through
to make it clear that what is about to happen is intended.
Good idea. Committed at 10df6121.

Thanks,

Scott

Loading...