[PATCH] CMake missing libMagic on mac

[Stephan Witt]

I cannot create Xcode project anymore because of the missing libMagic.
Somehow it's required now - but I think it shouldn't.

The attached patch works for me.
But I don't know if it's the right thing. Kornel?

Stephan

[Kornel Benko]

Post by Stephan Witt
I cannot create Xcode project anymore because of the missing libMagic.
Somehow it's required now - but I think it shouldn't.
The attached patch works for me.
But I don't know if it's the right thing. Kornel?
Stephan

It is required now, yes. Because of using symbols like 'magic_close' or 'magic_load'.

I will rewrite the module to be more cmake-like.
(Should use 'find_package_handle_standard_args()')

Also missing call to 'find_package(Magic REQUIRED)' at CMakeLists.txt:574

Kornel

[Stephan Witt]

Post by Kornel Benko

Post by Stephan Witt
I cannot create Xcode project anymore because of the missing libMagic.
Somehow it's required now - but I think it shouldn't.
The attached patch works for me.
But I don't know if it's the right thing. Kornel?
Stephan

It is required now, yes. Because of using symbols like 'magic_close' or 'magic_load'.
I will rewrite the module to be more cmake-like.
(Should use 'find_package_handle_standard_args()')
Also missing call to 'find_package(Magic REQUIRED)' at CMakeLists.txt:574

I don't understand. It cannot be required. It's not available on Mac.

Stephan

[Kornel Benko]

Post by Stephan Witt

Post by Kornel Benko

Post by Stephan Witt
I cannot create Xcode project anymore because of the missing libMagic.
Somehow it's required now - but I think it shouldn't.
The attached patch works for me.
But I don't know if it's the right thing. Kornel?
Stephan

It is required now, yes. Because of using symbols like 'magic_close' or 'magic_load'.
I will rewrite the module to be more cmake-like.
(Should use 'find_package_handle_standard_args()')
Also missing call to 'find_package(Magic REQUIRED)' at CMakeLists.txt:574

I don't understand. It cannot be required. It's not available on Mac.

OK, OK. Please try the patch sent in other mail. It works here, but I have to go now. Back in 2 hours.

Post by Stephan Witt
Stephan

Kornel

[Georg Baum]

Post by Stephan Witt

Post by Kornel Benko
Also missing call to 'find_package(Magic REQUIRED)' at CMakeLists.txt:574

I don't understand. It cannot be required. It's not available on Mac.

It is intended to be optional (but LyX works better if it is available). At
least in th source code it is correctly protected by HAVE_MAGIC_H.


Georg

[Stephan Witt]

Post by Georg Baum

Post by Stephan Witt

Post by Kornel Benko
Also missing call to 'find_package(Magic REQUIRED)' at CMakeLists.txt:574

I don't understand. It cannot be required. It's not available on Mac.

It is intended to be optional (but LyX works better if it is available). At
least in th source code it is correctly protected by HAVE_MAGIC_H.

Yes, I know. Kornel solved it already. Surely it is possible to include a self
made frame work in the LyX package. But I didn't try it until now.

Stephan

[Kornel Benko]

Post by Kornel Benko

Post by Stephan Witt
I cannot create Xcode project anymore because of the missing libMagic.
Somehow it's required now - but I think it shouldn't.
The attached patch works for me.
But I don't know if it's the right thing. Kornel?
Stephan

It is required now, yes. Because of using symbols like 'magic_close' or 'magic_load'.
I will rewrite the module to be more cmake-like.
(Should use 'find_package_handle_standard_args()')
Also missing call to 'find_package(Magic REQUIRED)' at CMakeLists.txt:574
Kornel

Corrected patch attached.
(And you are right, it is not required)

Kornel